pkg: remove use of sudo from the signing script #4206
Conversation
this is required as use of 'sudo' is not available in downstream build machines. while testing the built pkg with this changes crc is working as expected
|
/hold |
| @@ -49,7 +49,7 @@ sign "${crcBinDir}/crc" | |||
| sign "${crcBinDir}/crc-admin-helper-darwin" | |||
| sign "${crcBinDir}/vfkit" | |||
|
|
|||
| sudo chmod +sx "${crcBinDir}/crc-admin-helper-darwin" | |||
| chmod +sx "${crcBinDir}/crc-admin-helper-darwin" | |||
There was a problem hiding this comment.
If "${crcBinDir}/crc-admin-helper-darwin" is owned by the user running the script, both versions should be equivalent.
After installation though, crc-admin-helper-darwin must be owned by root and have the +s permission set, otherwise the binary won't be able to make changes to /etc/hosts Have you checked it's still fine?
There was a problem hiding this comment.
After create installer from this PR and run it I have this
podmanqe@dev-platform-mac4 ~ % ls -al /usr/local/crc
total 389096
drwxr-xr-x 5 root wheel 160 Jun 5 13:11 .
drwxr-xr-x 5 root wheel 160 Jun 5 13:12 ..
-rwxr-xr-x 1 root wheel 159483008 Jun 5 13:11 crc
-rwsr-sr-x 1 root wheel 5238656 Jun 5 13:11 crc-admin-helper-darwin
-rwxr-xr-x 1 root wheel 34489808 Jun 5 13:11 vfkit
There was a problem hiding this comment.
the installation needs to be run as root, since it installs in the / dir, and the files it creates are also owned by root
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cheery-pick main |
this is required as use of 'sudo' is not available in downstream build machines. while testing the built pkg with this changes crc is working as expected