Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image to centos:stream9 used for testing rpm build on ci #4210

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

anjannath
Copy link
Member

@openshift-ci openshift-ci bot requested review from cfergeau and evidolob June 5, 2024 16:15
@cfergeau
Copy link
Contributor

cfergeau commented Jun 6, 2024

This needs more changes to avoid

  > [6/6] RUN yum config-manager --set-enabled powertools &&     yum -y builddep packaging/rpm/crc.spec &&     rpmbuild -bb -v packaging/rpm/crc.spec:
0.370 Error: No matching repo to modify: powertools.

centos:stream8 has reached EOL as per:
https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/

the 'powertools' repository is now known as crb (code-ready-builder)
in centos stream 9
@anjannath
Copy link
Member Author

This needs more changes to avoid

  > [6/6] RUN yum config-manager --set-enabled powertools &&     yum -y builddep packaging/rpm/crc.spec &&     rpmbuild -bb -v packaging/rpm/crc.spec:
0.370 Error: No matching repo to modify: powertools.

yes updated now, the powertools repo is not available in centos9 have to use the repo crb

@anjannath
Copy link
Member Author

@cfergeau another question which is not directly related but the tests in the machine-driver-libvirt repo is also failing due to same centos:stream8 reaching EOL

but can we build machine-driver-libvirt on Centos Stream 9 and use it in RHEL 8, in the past there were issues with this because the glibc version is newer in RHEL 9/Centos Stream 9. how can we check if this is still the case?

Copy link

openshift-ci bot commented Jun 6, 2024

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc d47c071 link true /test e2e-crc
ci/prow/security 6ce7029 link false /test security
ci/prow/integration-crc 6ce7029 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cfergeau
Copy link
Contributor

cfergeau commented Jun 6, 2024

but can we build machine-driver-libvirt on Centos Stream 9 and use it in RHEL 8, in the past there were issues with this because the glibc version is newer in RHEL 9/Centos Stream 9. how can we check if this is still the case?

This most likely is still an issue, you can build machine-driver-libvirt in centos stream 9 and then try to start the resulting binary in an ubi8 image for example.

However, the binary that we ship is built on a rhel 8 system in RH build system, so the centos version we use in our Containerfiles should not be a problem?

Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@cfergeau cfergeau merged commit 829e538 into crc-org:main Jun 6, 2024
21 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] github actions RPM job is failing to install some packages
2 participants