-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 'sed -i' failure in Makefile for macOS #4226
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can we keep this 2 separate commits? (the I've filed #4227 which fixes more issues with the release-info check, but which will need the fixes from this PR. |
@lilyLuLiu can you drop c97baee one and have only one commit because other part is fix in #4227 |
@praveenkumar , Hi, I separated the commit as @cfergeau suggested. |
@lilyLuLiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/close changes merged with #4227 |
make release
fail with error message:The file
release-info.json
was moved to folder release. Thuscheck-release-info
can't find the filesed -i
failed in Makefile when running in MacOS