Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'sed -i' failure in Makefile for macOS #4226

Closed
wants to merge 2 commits into from

Conversation

lilyLuLiu
Copy link
Contributor

@lilyLuLiu lilyLuLiu commented Jun 12, 2024

make release fail with error message:

cat: release-info.json: No such file or directory

The file release-info.json was moved to folder release. Thus check-release-info can't find the file

sed -i failed in Makefile when running in MacOS

@openshift-ci openshift-ci bot requested review from cfergeau and gbraad June 12, 2024 09:17
Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau
Copy link
Contributor

Can we keep this 2 separate commits? (the sed changes and the cp->mv change)
Both will be needed, but they fix 2 very different things, so better to keep them separate.

I've filed #4227 which fixes more issues with the release-info check, but which will need the fixes from this PR.

@praveenkumar
Copy link
Member

@lilyLuLiu can you drop c97baee one and have only one commit because other part is fix in #4227

@lilyLuLiu
Copy link
Contributor Author

@praveenkumar , Hi, I separated the commit as @cfergeau suggested.

@lilyLuLiu lilyLuLiu changed the title small fix make release issue in linux fix 'sed -i' failure in Makefile for macOS Jun 13, 2024
Copy link

openshift-ci bot commented Jun 13, 2024

@lilyLuLiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 424f9ff link true /test e2e-microshift-crc
ci/prow/e2e-crc 424f9ff link true /test e2e-crc
ci/prow/integration-crc 424f9ff link true /test integration-crc
ci/prow/security 66b3e5d link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar
Copy link
Member

/close

changes merged with #4227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants