Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QE] fix can't catch error for "oc login" #4248

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[QE] fix can't catch error for "oc login" #4248

merged 1 commit into from
Jul 2, 2024

Conversation

lilyLuLiu
Copy link
Contributor

Fixes: Issue #4101

@lilyLuLiu lilyLuLiu changed the title [QE] fix can't catch error after execute shell cmd [QE] fix can't catch error for "oc login" Jun 24, 2024
@lilyLuLiu
Copy link
Contributor Author

/test e2e-crc

1 similar comment
@lilyLuLiu
Copy link
Contributor Author

/test e2e-crc

cfergeau
cfergeau reviewed Jul 1, 2024
View reviewed changes
test/extended/util/util.go Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 2, 2024

@lilyLuLiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 0aee073 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm label Jul 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@cfergeau cfergeau merged commit 22a112d into crc-org:main Jul 2, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfergeau cfergeau cfergeau approved these changes

@adrianriobo adrianriobo Awaiting requested review from adrianriobo

@anjannath anjannath Awaiting requested review from anjannath

Assignees

@cfergeau cfergeau

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilyLuLiu @cfergeau