-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update k8s and openshift go modules to sync with openshift-4.16 #4253
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git main is still using 4.15
Lines 5 to 7 in 926c78e
OPENSHIFT_VERSION ?= 4.15.17 | |
OKD_VERSION ?= 4.15.0-0.okd-2024-02-23-163410 | |
MICROSHIFT_VERSION ?= 4.15.17 |
This could go in the same PR as the one switching the Makefile to 4.16.
Yes, we can put it on hold till then, I don't think it break current master because from bundle side it is not going to break (no specific code at bundle side). |
/hold |
This updates the `github.com/openshift/*` modules to `release-4.16` and `k8s.io/*` to `v0.29.3`.
315c374
to
486ce3c
Compare
/unhold Updated the bundle to 4.16 also. |
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This updates the
github.com/openshift/*
modules torelease-4.16
andk8s.io/*
tov0.29.3
.