Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update k8s and openshift go modules to sync with openshift-4.16 #4253

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

praveenkumar
Copy link
Member

This updates the github.com/openshift/* modules to release-4.16 and k8s.io/* to v0.29.3.

@openshift-ci openshift-ci bot requested review from cfergeau and evidolob July 1, 2024 08:38
Copy link

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git main is still using 4.15

crc/Makefile

Lines 5 to 7 in 926c78e

OPENSHIFT_VERSION ?= 4.15.17
OKD_VERSION ?= 4.15.0-0.okd-2024-02-23-163410
MICROSHIFT_VERSION ?= 4.15.17
so it's a bit early for this change.
This could go in the same PR as the one switching the Makefile to 4.16.

@praveenkumar
Copy link
Member Author

o it's a bit early for this change.
This could go in the same PR as the one switching the Makefile to 4.16.

Yes, we can put it on hold till then, I don't think it break current master because from bundle side it is not going to break (no specific code at bundle side).

@praveenkumar
Copy link
Member Author

/hold

This updates the `github.com/openshift/*` modules to `release-4.16` and
`k8s.io/*` to `v0.29.3`.
@praveenkumar
Copy link
Member Author

/unhold

Updated the bundle to 4.16 also.

@praveenkumar praveenkumar added the has-to-be-in-release This PR need to go in coming release. label Jul 4, 2024
Copy link

openshift-ci bot commented Jul 4, 2024

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 486ce3c link false /test security
ci/prow/integration-crc 486ce3c link true /test integration-crc
ci/prow/e2e-crc 486ce3c link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit d3534af into crc-org:main Jul 8, 2024
20 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-to-be-in-release This PR need to go in coming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants