Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vfkit: Switch to EFIBootLoader from LinuxBootLoader (BIOS) #4309

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

praveenkumar
Copy link
Member

vfkit have a way to load efi bootloader and since we are now supporting only macos>13, better to switch it and it also allow a bit code clean around kernel update when start from stopped state.

Fixes: Issue #4308

@openshift-ci openshift-ci bot requested review from evidolob and gbraad August 7, 2024 11:09
Copy link

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

After the switch to UEFI, we can remove all the code related to
externally-provided kernel/initramfs/kernel command line.
Copy link

openshift-ci bot commented Aug 8, 2024

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-microshift-crc 4fd662a link true /test e2e-microshift-crc
ci/prow/images 4fd662a link true /test images
ci/prow/e2e-crc 4fd662a link true /test e2e-crc
ci/prow/integration-crc 4fd662a link true /test integration-crc
ci/prow/security 4fd662a link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vyasgun
Copy link
Contributor

vyasgun commented Aug 8, 2024

Tested this and it is working. The corresponding vfkit command:
/Users/podmanqe/.crc/bin/vfkit --cpus 2 --memory 4096 --bootloader efi,variable-store=/Users/podmanqe/.crc/machines/crc/efistore.nvram,create --device virtio-serial,logFilePath=/Users/podmanqe/.crc/machines/crc/vfkit.log --device virtio-fs,sharedDir=/Users/podmanqe,mountTag=dir0 --device virtio-rng --device virtio-blk,path=/Users/podmanqe/.crc/machines/crc/crc.img --device virtio-vsock,port=1024,socketURL=/Users/podmanqe/.crc/tap.sock,listen --timesync vsockPort=1234

@praveenkumar praveenkumar merged commit ab63fcd into crc-org:main Aug 13, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants