Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub action that use Testing Farm #4320

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

lilyLuLiu
Copy link
Contributor

@lilyLuLiu lilyLuLiu commented Aug 19, 2024

Copy link

openshift-ci bot commented Aug 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lilyLuLiu
Copy link
Contributor Author

I need to log in to the self-host runner to do some debug. So need to add my ssh public key into the github self-host runner from the testing farm. Waitting for https://gitlab.com/testing-farm/infrastructure/-/merge_requests/698 to be merged now.

@lilyLuLiu
Copy link
Contributor Author

lilyLuLiu commented Oct 22, 2024

@adrianriobo Hi, I'm debugging run crc tests with machine from TestingFarm.

The issue is, we can only use the self-host runner(also from TestingFarm) to provision and connect to the arm64 machine from TestingFarm. That means we can't connect to the machine with a container(deliverset image).
When provision a TestingFarm machine, the ssh public key of proxy will be added into the runner, thus the runner can connect to the reserved machine through proxy.

So I think we can't use the container method to run crc tests with Testing Farm.
Do we move to other test way?

.github/workflows/linux-artifacts.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
echo $SSH_AGENT_PID > ssh_agent_pid
#kill $(cat ssh_agent_pid)
ssh-add id_rsa

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need api invoke to add this as check for the PR

- name: Add status to the PR check
this previously need to correlate the execution https://github.com/crc-org/crc/blob/main/.github/workflows/windows-qe-tpl.yml#L61

.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM although I would prefer to tackle the comments. Although I am also fine if you want to have it in ASAP and the create a follow up one to fix the comments.

@@ -40,6 +40,14 @@ jobs:
with:
name: windows-installer
path: "./out/windows-amd64/crc-windows-installer.zip"
- name: Build Linux binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a follow up issue on this one, about to renaming this action (as now it also includes linux build, it would be great to properly name it).

Also ensure linux build is only done in one place

.github/workflows/linux-qe-test.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe-template.yml Outdated Show resolved Hide resolved
.github/workflows/linux-qe-template.yml Show resolved Hide resolved
-v "$(cat ssh_auth_sock):$(cat ssh_auth_sock)" \
-v ${PWD}:/data:z \
-v ${PWD}/crc:/opt/crc-support/crc:z \
quay.io/rhqp/crc-support:v0.5.1-linux crc-support/install.sh crc-support/crc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quay.io/crc-org/ci-crc-support:v1.0.0-linux Is now available. If possible change to this as from now on it should be the "official" one.

Let me do a check on using it directly with crc as a local asset. And will add here the snippet to make use of it here.

Copy link

openshift-ci bot commented Nov 15, 2024

@lilyLuLiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc c665931 link true /test integration-crc
ci/prow/e2e-crc c665931 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 18, 2024

New changes are detected. LGTM label has been removed.

@lilyLuLiu lilyLuLiu merged commit 0b4c663 into crc-org:main Nov 18, 2024
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants