Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump github.com/golangci/golangci-lint in /tools" #4324

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

praveenkumar
Copy link
Member

This reverts commit 831c5f9.

Since https://github.com/golangci/golangci-lint/blob/v1.60.1/go.mod is moved to go-1.22.1 and with this update go toolchain now require 1.22.1 version. RHEL-9 builds still on go-1.21

This reverts commit 831c5f9.

Since https://github.com/golangci/golangci-lint/blob/v1.60.1/go.mod is
moved to go-1.22.1 and with this update go toolchain now require 1.22.1
version. RHEL-9 builds still on go-1.21
@openshift-ci openshift-ci bot requested review from cfergeau and gbraad August 21, 2024 04:30
Copy link

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 21, 2024

@praveenkumar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 5260dfd link false /test security
ci/prow/e2e-crc 5260dfd link true /test e2e-crc
ci/prow/integration-crc 5260dfd link true /test integration-crc
ci/prow/e2e-microshift-crc 5260dfd link true /test e2e-microshift-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit 8bcc1b9 into crc-org:main Aug 21, 2024
19 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants