Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QE] minimal improvements around windows qe gh actions #4363

Merged
merged 3 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/windows-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ on:

jobs:
windows-e2e-ocp:
# https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_run
if: |
github.event.workflow_run.conclusion == 'success' &&
env.source_event == 'pull_request' &&
github.event.workflow_run.triggering_actor != 'dependabot[bot]'
uses: crc-org/crc/.github/workflows/windows-qe-tpl.yml@main
strategy:
fail-fast: false
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/windows-qe-tpl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
-e ARM_CLIENT_SECRET='${{secrets.ARM_CLIENT_SECRET}}' \
-e AZURE_STORAGE_ACCOUNT='${{ secrets.AZURE_STORAGE_ACCOUNT }}' \
-e AZURE_STORAGE_KEY='${{ secrets.AZURE_STORAGE_KEY }}' \
quay.io/redhat-developer/mapt:v0.6.6 azure \
quay.io/redhat-developer/mapt:v0.6.9 azure \
windows create \
--project-name 'windows-desktop-${{ matrix.windows-version }}-${{ matrix.windows-featurepack }}-${{inputs.qe-type}}-${{inputs.preset}}' \
--backed-url azblob://crc-qenvs-state/${{ github.repository }}-${{ github.run_id }} \
Expand Down Expand Up @@ -149,7 +149,10 @@ jobs:
else
cmd="${cmd} -e2eTagExpression '~@minimal && ~@story_microshift'"
fi
else
cmd="${cmd} -suiteTimeout 120m"
fi

podman run --rm -d --name crc-${{inputs.qe-type}} \
-e TARGET_HOST=$(cat host) \
-e TARGET_HOST_USERNAME=$(cat username) \
Expand Down Expand Up @@ -218,7 +221,7 @@ jobs:
-e ARM_CLIENT_SECRET='${{secrets.ARM_CLIENT_SECRET}}' \
-e AZURE_STORAGE_ACCOUNT='${{ secrets.AZURE_STORAGE_ACCOUNT }}' \
-e AZURE_STORAGE_KEY='${{ secrets.AZURE_STORAGE_KEY }}' \
quay.io/redhat-developer/mapt:v0.6.6 azure \
quay.io/redhat-developer/mapt:v0.6.9 azure \
windows destroy \
--project-name 'windows-desktop-${{ matrix.windows-version }}-${{ matrix.windows-featurepack }}-${{inputs.qe-type}}-${{inputs.preset}}' \
--backed-url azblob://crc-qenvs-state/${{ github.repository }}-${{ github.run_id }}
Expand Down