Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark some tests only for releases #4383

Merged
merged 1 commit into from
Oct 2, 2024
Merged

mark some tests only for releases #4383

merged 1 commit into from
Oct 2, 2024

Conversation

albfan
Copy link
Contributor

@albfan albfan commented Oct 1, 2024

Fixes: Issue #4381

Copy link
Contributor

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change a bit the commit message, i.e.

[QE] Added a new e2e annotation to identify test to be executed only during release testing

During nightly e2e the crc version test is giving a false positive due to how we check the versions for the code tested and the version of the tests themselves. This version test makes no sense during nightly but it make sense during release testing. This commit will include an annotation to allow us pick the test only during release testing

…during release testing

During nightly e2e the crc version test is giving a false positive due to how we check the versions for the code tested and the version of the tests themselves. This version test makes no sense during nightly but it make sense during release testing. This commit will include an annotation to allow us pick the test only during release testing
@albfan
Copy link
Contributor Author

albfan commented Oct 2, 2024

@adrianriobo message changed

Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 2, 2024
Copy link

openshift-ci bot commented Oct 2, 2024

@albfan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc b7738e8 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adrianriobo adrianriobo merged commit 3f62a38 into main Oct 2, 2024
26 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants