Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabular explainability #188

Merged
merged 24 commits into from
Oct 29, 2024
Merged

Tabular explainability #188

merged 24 commits into from
Oct 29, 2024

Conversation

olivier-bernard-creatis
Copy link
Contributor

To be analyzed ideally before this Thursday ;)

Copy link
Member

@nathanpainchaud nathanpainchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great review! Just a few typo corrections and phrasing suggestions.

collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
* Transformers posses a built-in capability to provide explanations for its results via the analysis of attention matrices

<div style="text-align:center">
<img src="/collections/images/tabular_explainability/tab_exp_1.jpg" width=700></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe correct bloc to block in the figure, but I would understand if you don't want to bother 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
collections/_posts/2024-10-20-tabular-explainability.md Outdated Show resolved Hide resolved
olivier-bernard-creatis and others added 20 commits October 29, 2024 11:00
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
Co-authored-by: Nathan Painchaud <23144457+nathanpainchaud@users.noreply.github.com>
@olivier-bernard-creatis
Copy link
Contributor Author

Thanks Nathan for your numerous feedback ;)
I took care of every one of them

@nathanpainchaud
Copy link
Member

Thanks Nathan for your numerous feedback ;) I took care of every one of them

My pleasure :)

I just wanted to point out that 2 comments have not been adressed: one for updating bloc to block in the figure, and the other on line 89 (you answered the comment in your reply but didn't apply the change to the post itself 😉).

@olivier-bernard-creatis
Copy link
Contributor Author

Oups, I just forget to push my commit ;)
This is done

@nathanpainchaud nathanpainchaud merged commit 0289e87 into main Oct 29, 2024
2 checks passed
@nathanpainchaud nathanpainchaud deleted the tabular_explainability branch October 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants