Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby version for Windows in the contribution guide #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HangJung97
Copy link
Member

The latest version of Ruby causes issues when installing wdm on Windows machines. The version 3.1.2-1 works fine without errors.

@HangJung97 HangJung97 added the bug Something isn't working label Dec 5, 2024
@HangJung97 HangJung97 self-assigned this Dec 5, 2024
@nathanpainchaud
Copy link
Member

I don't see a strong reason to demand the latest version of ruby for the project. However, I'd have 2 questions to make sure simply installing a new version will work:

  • When I follow the link to the download page for Ruby, I see that the version 3.1.2 is not just the version before the latest one. Did you chose it because it was the one you had on your system, so you know it would work? Because I suspect that if there are issues with the latest version (3.3.6?), maybe the latest version of a previous stable branch (e.g. 3.2.x, 3.1.x) could work? And if so, it probably is a better candidate to pin the ruby version.
  • Given that the Gemfile.lock for the dependencies is checked into version control, have you tested if the lockfile still works (without requiring any modification) for the specific Ruby version?

@HangJung97
Copy link
Member Author

At the installation section for Windows users, I previously wrote the latest version of Ruby. The latest version 3.3.x is no longer compatible with the dependencies of this project.

I chose this version because it is the closest version to the one I have on my PC. I have tested with Sarra, and it worked with the current Gemfile.lock without any errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants