MNT Fix scss lint warnings

creative-commoners · Jun 5, 2024 · 8e50301 · 8e50301
1 parent 7d5c403
commit 8e50301
Show file tree

Hide file tree

Showing 6 changed files with 456 additions and 849 deletions.
diff --git a/client/dist/styles/bundle.css b/client/dist/styles/bundle.css
diff --git a/client/src/styles/bundle.scss b/client/src/styles/bundle.scss
@@ -3,7 +3,6 @@
 // Import variables
 @import "variables"; // from silverstripe/admin
 @import "login-forms-variables";
-
 @import "typography";
 @import "layout";
 @import "brand";

diff --git a/client/src/styles/dark-mode.scss b/client/src/styles/dark-mode.scss
@@ -7,12 +7,10 @@
     --color-button-primary-hover-background: #{$dark-color-button-primary-hover-background};
     --color-button-primary-text: #{$dark-color-button-primary-text};
     --color-button-primary-hover-text: #{$dark-color-button-primary-hover-text};
-
     --color-button-secondary-background: transparent;
     --color-button-secondary-hover-background: #{$dark-color-button-secondary-hover-background};
     --color-button-secondary-text: #{$dark-color-button-secondary-text};
     --color-button-secondary-hover-text: #{$dark-color-button-secondary-hover-text};
-
     --color-field-background: #{$dark-color-field-background};
     --color-field-border: #{$dark-color-field-border};
     --color-field-text: #{$dark-color-field-text};
@@ -31,6 +29,7 @@
   &__logo--dark-mode {
     display: none;
   }
+
   @media (prefers-color-scheme: dark) {
     &__logo--light-mode {
       display: none;

diff --git a/client/src/styles/login-form.scss b/client/src/styles/login-form.scss
@@ -14,7 +14,7 @@ html {
   padding: var(--spacing-form);
   width: 100vw;
 
-  @media (min-width: 420px) {
+  @media (width >= 420px) {
     border-radius: var(--border-radius-form);
     padding: var(--spacing-form-desktop);
     width: auto;
@@ -143,7 +143,7 @@ input[type="submit"] {
     }
   }
 
-  &:not(:disabled):not(.disabled) {
+  &:not(:disabled, .disabled) {
     &:hover,
     &:focus,
     &.focus,
@@ -178,7 +178,7 @@ input[type="submit"] {
     }
   }
 
-  &:not(:disabled):not(.disabled) {
+  &:not(:disabled, .disabled) {
     &:hover,
     &:focus,
     &.focus,
@@ -213,14 +213,15 @@ input[type="checkbox"] {
 
   // Style the notch on the popup bottle for each possible position
   $positions: top, bottom, left, right;
+
   @each $pos in $positions {
     &.bs-popover-auto[x-placement^="#{$pos}"],
     &.bs-popover-#{$pos} {
-      & > .arrow::before {
+      > .arrow:before {
         border-#{$pos}-color: var(--color-field-border);
       }
 
-      & > .arrow::after {
+      > .arrow:after {
         border-#{$pos}-color: var(--color-form-background);
       }
     }

diff --git a/client/src/styles/login-forms-variables.scss b/client/src/styles/login-forms-variables.scss
@@ -54,12 +54,10 @@ $spacing-submit-content: 10px 20px;
   --color-button-secondary-hover-background: #{$color-button-secondary-hover-background};
   --color-button-secondary-text: #{$link-color};
   --color-button-secondary-hover-text: #{$link-color};
-
   --color-button-primary-background: #{$color-button-primary-background};
   --color-button-primary-hover-background: #{$color-button-primary-hover-background};
   --color-button-primary-text: #{$color-button-primary-text};
   --color-button-primary-hover-text: #{$color-button-primary-hover-text};
-
   --color-field-background: #{$white};
   --color-field-border: #{$gray-200};
   --color-field-text: #{$gray-800};
@@ -70,15 +68,12 @@ $spacing-submit-content: 10px 20px;
   --color-message-warning: #{$color-message-warning};
   --color-page-background: #{$color-page-background};
   --color-page-text: #{$gray-800};
-
   --border-radius-form: #{$border-radius-form};
   --border-radius-field: #{$border-radius-field};
   --box-shadow-form: #{$box-shadow-form};
-
   --sizing-app-brand-max-height: #{$sizing-app-brand-max-height};
   --sizing-app-brand-max-width: #{$sizing-app-brand-max-width};
   --sizing-content-width: #{$sizing-content-width};
-
   --spacing-app-brand: #{$spacing-app-brand};
   --spacing-field-content: #{$spacing-field-content};
   --spacing-form: #{$spacing-form};