[Feature] Improve legal code language selection/fallback #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
This pull request addresses the improvement of the legal code language selection and fallback logic in the
cc-legal-tools-app
. The current fallback mechanism for legal code translations uses a naive method, which has been updated to a more robust approach similar to the Deeds & UX translation logic.The changes include:
load_legal_code_translations()
to populate available legal code translations.get_default_language_for_jurisdiction_naive()
function withget_default_language_for_jurisdiction_legal_code()
for a more sophisticated fallback logic based on the newly addedsettings.LANGUAGES_AVAILABLE_LEGAL_CODE
.get_default_language_for_jurisdiction_deed()
toget_default_language_for_jurisdiction_deed_ux()
to clarify its scope.Technical details
load_legal_code_translations()
function populatessettings.LANGUAGES_AVAILABLE_LEGAL_CODE
with the available languages for each jurisdiction.settings.LANGUAGES_AVAILABLE_LEGAL_CODE
. If not, it falls back to the default language specified in thesettings.LANGUAGE_CODE
.Tests
To verify:
settings.LANGUAGES_AVAILABLE_LEGAL_CODE
.Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin