Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fixes Heading Overflow in mobile devices #837

Conversation

SumaiyaaRq
Copy link
Contributor

@SumaiyaaRq SumaiyaaRq commented Oct 25, 2024

Fixes

Description

This PR solves the issue of 'overflowing heading in mobile devices causing scrolling' by adding specific styles for smaller devices using media queries.

Technical details

Modified: homepage.scss file by adding media queries for devices having with <=530px.

Tests

  1. Open the project.
  2. Right-click and select Inspect (or press Ctrl+Shift+I / Cmd+Option+I on Mac).
  3. Click Toggle Device Toolbar (or press Ctrl+Shift+M / Cmd+Shift+M on Mac ).
  4. Select small screen size
  5. See correction.

Screenshots

Screenshot 2024-10-25 at 4 59 09 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@SumaiyaaRq SumaiyaaRq requested review from a team as code owners October 25, 2024 11:32
@SumaiyaaRq SumaiyaaRq requested review from TimidRobot, Shafiya-Heena and Cronus1007 and removed request for a team October 25, 2024 11:32
@TimidRobot TimidRobot self-assigned this Nov 5, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work!

@TimidRobot TimidRobot merged commit 5935a9b into creativecommons:main Nov 5, 2024
1 check passed
@SumaiyaaRq
Copy link
Contributor Author

Thank you for approving !

@SumaiyaaRq SumaiyaaRq deleted the fix/heading-overflow-in-small-screens branch November 6, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Headings overflow on mobile devices causing scroll requirement
2 participants