-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified Logic to check for optional excerpt #845
Merged
TimidRobot
merged 7 commits into
creativecommons:main
from
Queen-codes:add-excerpt-field-logic
Dec 10, 2024
Merged
Modified Logic to check for optional excerpt #845
TimidRobot
merged 7 commits into
creativecommons:main
from
Queen-codes:add-excerpt-field-logic
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queen-codes
requested review from
TimidRobot,
Shafiya-Heena and
dhruvkb
and removed request for
a team
November 6, 2024 09:33
TimidRobot
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to support markdown excerpts
TimidRobot
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work, thank you!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
This PR modifies the logic that truncates the first 100 characters of the blog post to serve as the excerpt which checks to see if the author provided an excerpt that can be used. If an excerpt is provided, it is used, if not, it falls to the default behaviour.
Technical details
I modified the logic in
posts.html
, added the excerpt field to thecontents.lr
file of the write a blog page, and added an excerpt field to theblog-post.ini
file to ensure the excerpt field was read correctly.Tests
To test that the logic worked, I added a dummy blog post to the
entries
folder and an excerpt field in thecontents.lr
file.Screenshots
The added dummy post for testing
The preview it provided
Write a blog post page to show excerpt field in the format provided
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin