Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove twitter logo from footer #847

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Remove twitter logo from footer #847

merged 1 commit into from
Dec 3, 2024

Conversation

Prince-Tagadiya
Copy link
Contributor

@Prince-Tagadiya Prince-Tagadiya commented Dec 1, 2024 •
edited by TimidRobot
Loading

Fixes

Description

This pull request removes the outdated Twitter logo from the footer section and updates it with the new X logo, as per the current brand guidelines.

Technical details

  • Removed the old Twitter logo from the footer.
  • If necessary, replace it with the new X logo or update the code to leave the section as is (depending on the project requirements).

Tests

To verify the changes:

  1. Go to https://opensource.creativecommons.org.
  2. Scroll to the footer section.
  3. Ensure the Twitter logo is no longer visible and the section looks correct without it.

Screenshots

before
Screenshot 2024-12-01 at 23 52 20

after
Screenshot 2024-12-01 at 23 52 42

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the default branch (main or master).
  • My commit messages follow best practices.
  • My code adheres to the repository’s established coding style.
  • I have tested the changes locally and ensured there are no visible errors.

@Prince-Tagadiya Prince-Tagadiya requested review from a team as code owners December 1, 2024 18:17
@Prince-Tagadiya Prince-Tagadiya requested review from TimidRobot, Shafiya-Heena and Dhruvi16 and removed request for a team December 1, 2024 18:17
@TimidRobot TimidRobot self-assigned this Dec 3, 2024
TimidRobot
TimidRobot approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thank you!

@TimidRobot TimidRobot merged commit 12daae0 into creativecommons:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimidRobot TimidRobot TimidRobot approved these changes

@Shafiya-Heena Shafiya-Heena Awaiting requested review from Shafiya-Heena Shafiya-Heena is a code owner automatically assigned from creativecommons/technology

@Dhruvi16 Dhruvi16 Awaiting requested review from Dhruvi16 Dhruvi16 is a code owner automatically assigned from creativecommons/ct-cc-open-source-core-committers

Assignees

@TimidRobot TimidRobot

Labels
None yet
Projects
TimidRobot
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The footer has old twitter logo that needs to be updated
2 participants
@Prince-Tagadiya @TimidRobot