Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored featured projects section code to align with vocabulary context for projects #854

Conversation

Queen-codes
Copy link
Contributor

@Queen-codes Queen-codes commented Dec 17, 2024

Fixes

Description

This PR updates the markup for the featured projects section to align with the projects section in the program-index.html context.

Screenshots

Before
Screenshot 2024-12-17 at 14 14 20

Current look after refactoring
Screenshot 2024-12-17 at 14 15 48

Guide/ Reference: The aim is for it to look somewhat similar to this
Screenshot 2024-12-17 at 13 32 50

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners December 17, 2024 13:18
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and akmadian and removed request for a team December 17, 2024 13:18
@Queen-codes Queen-codes marked this pull request as draft December 17, 2024 13:18
@Queen-codes
Copy link
Contributor Author

Hi @TimidRobot,

The Vocabulary context provided for this component doesn’t account for elements like external links, Slack channels, or tags, which are present in the current featured projects section. Here’s what I have so far with the new markup.

Since we previously discussed aligning the markup first (even if it looks a bit off) and then determining how to handle local design changes, I’m wondering: Is there a way to reintroduce elements like the external links, Slack channels, or tags back into the new code, or leave it as is for now?

Let me know what you think!

@TimidRobot
Copy link
Member

Hi @TimidRobot,

The Vocabulary context provided for this component doesn’t account for elements like external links, Slack channels, or tags, which are present in the current featured projects section. Here’s what I have so far with the new markup.

Since we previously discussed aligning the markup first (even if it looks a bit off) and then determining how to handle local design changes, I’m wondering: Is there a way to reintroduce elements like the external links, Slack channels, or tags back into the new code, or leave it as is for now?

Let me know what you think!

@Queen-codes my recommendation is to avoid making CSS changes and for HTML to either:

  • include "old" content HTML, where nothing exists in Vocabulary
    • if HTML looks good, no additional action
    • If HTML looks a little bad, update it to match Vocabulary standards or add a TODO comment
    • if HTML looks very bad, add a TODO comment and comment it out
  • include commented out "old" content HTML where including it seems out of scope of the existing effort/pull request

@Queen-codes
Copy link
Contributor Author

Hi @TimidRobot,
The Vocabulary context provided for this component doesn’t account for elements like external links, Slack channels, or tags, which are present in the current featured projects section. Here’s what I have so far with the new markup.
Since we previously discussed aligning the markup first (even if it looks a bit off) and then determining how to handle local design changes, I’m wondering: Is there a way to reintroduce elements like the external links, Slack channels, or tags back into the new code, or leave it as is for now?
Let me know what you think!

@Queen-codes my recommendation is to avoid making CSS changes and for HTML to either:

  • include "old" content HTML, where nothing exists in Vocabulary

    • if HTML looks good, no additional action
    • If HTML looks a little bad, update it to match Vocabulary standards or add a TODO comment
    • if HTML looks very bad, add a TODO comment and comment it out
  • include commented out "old" content HTML where including it seems out of scope of the existing effort/pull request

thank you. this is helpful

@Queen-codes
Copy link
Contributor Author

Queen-codes commented Dec 20, 2024

This seems like a duplicate effort as it is part of changes made in #856 . If you agree, @TimidRobot . I'll go ahead and close it up.

@TimidRobot
Copy link
Member

This seems like a duplicate effort as it is part of changes made in #856 . If you agree, @TimidRobot . I'll go ahead and close it up.

* [refactored open source website's home page to implement and align with vocabulary #856](https://github.com/creativecommons/creativecommons.github.io-source/pull/856)

Yep, I think you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ status: discarded Will not be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants