-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored featured projects section code to align with vocabulary context for projects #854
refactored featured projects section code to align with vocabulary context for projects #854
Conversation
Hi @TimidRobot, The Vocabulary context provided for this component doesn’t account for elements like external links, Slack channels, or tags, which are present in the current featured projects section. Here’s what I have so far with the new markup. Since we previously discussed aligning the markup first (even if it looks a bit off) and then determining how to handle local design changes, I’m wondering: Is there a way to reintroduce elements like the external links, Slack channels, or tags back into the new code, or leave it as is for now? Let me know what you think! |
@Queen-codes my recommendation is to avoid making CSS changes and for HTML to either:
|
thank you. this is helpful |
This seems like a duplicate effort as it is part of changes made in #856 . If you agree, @TimidRobot . I'll go ahead and close it up. |
Yep, I think you're right |
Fixes
Description
This PR updates the markup for the featured projects section to align with the projects section in the
program-index.html
context.Screenshots
Before
Current look after refactoring
Guide/ Reference: The aim is for it to look somewhat similar to this
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin