chore: return insufficient fee error nicely

x/amm/keeper/pool.go

@@ -22,6 +22,7 @@ func (k Keeper) CreatePool(ctx sdk.Context, creatorAddr sdk.AccAddress, marketId
 
 	creationFee := k.GetPoolCreationFee(ctx)
 	if err = k.bankKeeper.SendCoinsFromAccountToModule(ctx, creatorAddr, types.ModuleName, creationFee); err != nil {
+		err = sdkerrors.Wrap(err, "insufficient pool creation fee")
 		return
 	}
 

x/amm/keeper/pool_test.go

@@ -25,7 +25,7 @@ func (s *KeeperTestSuite) TestCreatePool_InsufficientFee() {
 	market := s.CreateMarket("ucre", "uusd")
 	creatorAddr := utils.TestAddress(1)
 	_, err := s.keeper.CreatePool(s.Ctx, creatorAddr, market.Id, utils.ParseDec("5"))
-	s.Require().EqualError(err, "0ucre is smaller than 100000000ucre: insufficient funds")
+	s.Require().EqualError(err, "insufficient pool creation fee: 0ucre is smaller than 100000000ucre: insufficient funds")
 }
 
 func (s *KeeperTestSuite) TestCreatePool() {

x/exchange/keeper/market.go

@@ -24,7 +24,7 @@ func (k Keeper) CreateMarket(
 	fees := k.GetFees(ctx)
 	if err = k.bankKeeper.SendCoinsFromAccountToModule(
 		ctx, creatorAddr, types.ModuleName, fees.MarketCreationFee); err != nil {
-		return
+		return market, sdkerrors.Wrap(err, "insufficient market creation fee")
 	}
 
 	marketId := k.GetNextMarketIdWithUpdate(ctx)

x/exchange/keeper/market_test.go

@@ -0,0 +1,22 @@
+package keeper_test
+
+import (
+	utils "github.com/crescent-network/crescent/v5/types"
+)
+
+func (s *KeeperTestSuite) TestCreateMarket() {
+	creatorAddr := s.FundedAccount(1, enoughCoins)
+	_, err := s.keeper.CreateMarket(s.Ctx, creatorAddr, "nonexistent1", "nonexistent2")
+	s.Require().EqualError(err, "base denom nonexistent1 has no supply: invalid request")
+	_, err = s.keeper.CreateMarket(s.Ctx, creatorAddr, "ucre", "nonexistent2")
+	s.Require().EqualError(err, "quote denom nonexistent2 has no supply: invalid request")
+
+	s.CreateMarket("ucre", "uusd")
+
+	_, err = s.keeper.CreateMarket(s.Ctx, creatorAddr, "ucre", "uusd")
+	s.Require().EqualError(err, "market already exists: 1: invalid request")
+
+	emptyAddr := utils.TestAddress(2)
+	_, err = s.keeper.CreateMarket(s.Ctx, emptyAddr, "uatom", "uusd")
+	s.Require().EqualError(err, "insufficient market creation fee: 0stake is smaller than 1000000stake: insufficient funds")
+}