refactor: use sdk.Dec for quantities #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcre
requested review from
crypin,
richard-bachman and
lv-koala
as code owners
also add test for decimal quantity
instead use Escrow type
also split files
having performance issue, need to solve it afterward
|
Please let me know when it ready for review |
|
@crypin It's now ready |
9 tasks
crypin
requested changes
Aug 2, 2023
Comment on lines
170
to
+171
| } else if amtInDiff.IsNegative() { // sanity check | ||
| //panic(amtInDiff) | ||
| panic(amtInDiff) |
There was a problem hiding this comment.
I think this part is likely to happen, I will share the detailed scenario again as soon as it is sorted out
|
Merging this PR and the remaining issues will be handled in separate issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
sdk.Decinstead ofsdk.Int(alsosdk.DecCoininstead ofsdk.Coin) in x/exchange. This will reduce errors caused by decimal truncation.Tasks
QueueSendCoinsandExecuteSendCoins, instead use newEscrowtype