docs: update docs #199
Merged
docs: update docs #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kingcre
requested review from
crypin,
richard-bachman and
lv-koala
as code owners
crypin
reviewed
Sep 8, 2023
There was a problem hiding this comment.
- Is there a reason why
x/liquidamm/specpart is empty? Will it be added later? - I think we need to update the module name used for this part
- This is another issue, but it seems necessary to discuss whether the voting power related to liquidamm balance including btoken should be added to the liquidstaking liquid gov part
Updated
Handled in #201, in this file.
Handled in #201. |
crypin
reviewed
Sep 11, 2023
| A bidder only can place a single bid per auction of a liquid farm. | ||
| The bid amount of the pool coin must be higher than the current winning bid amount that is the highest bid amount of the auction at the moment. | ||
| The bidder placing the bid with the highest amount of the pool coin becomes the winner of the auction and will takes all the accumulated rewards amount at the end of the auction. | ||
| ## LiquidAMM |
There was a problem hiding this comment.
Looks still empty of some LiquidAmm parts
Is it missing or will it be added later in a separate PR?
There was a problem hiding this comment.
I think we should add it later in a separate PR.
There was a problem hiding this comment.
If it's not going to proceed right away, it would be good to create an issue or task so that we don't miss it
crypin
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes updates in API and CLI docs.