Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will it be upgraded to Valet V4? #210

Open
mreduar opened this issue Mar 15, 2023 · 10 comments
Open

Will it be upgraded to Valet V4? #210

mreduar opened this issue Mar 15, 2023 · 10 comments

Comments

@mreduar
Copy link

mreduar commented Mar 15, 2023

Hi, I wanted to ask if you are planning to upgrade to the recently released version 4. It brings good improvements, but I see that this repository has not been updated in a long time and is way behind the fork. I guess it must be difficult to keep it up to date on the Windows side as it must be very different.

@mreduar mreduar changed the title Will it be upgraded to Vale V4? Will it be upgraded to Valet V4? Mar 15, 2023
@Sophist-UK
Copy link

I would also be interested in a Valet v4 version. If you need help supporting this and are willing to share ownership I might be able to help.

@rabiibrahimi
Copy link

Not sure but looks this project is abended. is it ?

@Sophist-UK
Copy link

@cretueusebiu Are you still maintaining this? If not would you be willing to open it up to contributions?

@cretueusebiu
Copy link
Owner

I think it would be easier to just port it again from the original code.
I can give access to the repo if you or anyone else wants to help.

@Sophist-UK
Copy link

If we are going to do that it might make sense to approach Taylor and see if we can get him to include these changes in the original so that it supports both Mac and Windows.

@Sophist-UK
Copy link

Just how difficult / easy was it to take the Mac version and make it work on Windows?

@cretueusebiu
Copy link
Owner

Back in the original version or version 2 things were pretty simple but now there is bit more code to manage with all the added features.
The problem is that there isn't 100% parity between the Mac and Windows version so on the Windows version you have to find some alternatives and "hacks" and I don't think they would want to make so many changes in the original code for Windows support.

@ghost
Copy link

ghost commented Apr 12, 2023

Correct me if I am wrong, but it looks like Laravel 11 will require 8.2 which would take a few changes in the php download script. Maybe update nginix to the latest? I would like to work on this as well.

@yCodeTech
Copy link

yCodeTech commented May 20, 2023

Hi everyone.
I've been working on my own fork of valet windows, since this one is no longer maintained, and I hope to release it as Laravel Valet Windows 3 in the near future. I hope to gain as much parity as possible. I've already completed various additions and updates inline with the mac version, and including some PRs from this fork.

I've not yet added it to packagist and I'm in process of writing some docs for it. However, you should be able to still use it via a composer repository requirement with the namespace ycodetech/valet-windows. This is still in active development, so breaking changes could happen at any point.

For any further suggestions, issues or PRs please make them in my new fork.

Collaborators are welcome, just let me know.

Edit

Laravel Valet Windows 3 has been officially released as 3.0.0! Install it with composer global require ycodetech/valet-windows

@adevade
Copy link

adevade commented May 30, 2023

@Sophist-UK

If we are going to do that it might make sense to approach Taylor and see if we can get him to include these changes in the original so that it supports both Mac and Windows.

Matt, who is maintaining the official Valet, had a PR going for multi-OS support but decided it was too much maintenance. And I believe that didn't even include Windows yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants