Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash_remove and use in transp to fix #261 #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balgillo
Copy link

@balgillo balgillo commented Sep 6, 2022

Fix for #261

  • Add a new hash_remove function which works like hash_flush but for a single hashtable entry.
  • Remove mem_deref calls from transp.c and use hash_remove in close_conn instead.
    • This ensures that when the conn has already been removed from the hashtable, e.g. by hash_flush(sip->ht_conn),
      there is no extra mem_deref in transp.c.

Testing done

  • Compiles fine
  • retest -r passes
  • Tested within two proprietary, internal test suites written in Python
  • I have not reproduced this issue in pure C code due to the lack of request tests in retest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant