-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add go/types based template type checking #17
Draft
crhntr
wants to merge
29
commits into
main
Choose a base branch
from
type-check-templates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhntr
force-pushed
the
type-check-templates
branch
from
December 2, 2024 05:15
36c18cd
to
a476f5c
Compare
crhntr
force-pushed
the
type-check-templates
branch
from
December 21, 2024 02:24
a07c3ca
to
3bc8f7a
Compare
crhntr
force-pushed
the
type-check-templates
branch
from
December 21, 2024 04:06
3bc8f7a
to
ff6bdbd
Compare
crhntr
force-pushed
the
type-check-templates
branch
from
December 27, 2024 02:16
d5e4b61
to
021d09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to do a source based type checker for templates. I intend to add this to muxt generate and have it run at the end.
Here is some related work art:
This PR is intended to resolve: #3
Design
The signature of the tree based type checker.
Since, safehtml/template, html/template, and text/template all use text/template/parse, the Tree type from parse makes sense as a parameter to the checker.