Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stream close #2

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix stream close #2

merged 2 commits into from
Oct 5, 2023

Conversation

mr-linch
Copy link
Contributor

@mr-linch mr-linch commented Oct 4, 2023

resolve #1

  • use bufio.ReadWriter for send close event
  • add net.Conn to Stream
  • add test for close

cristaloleg
cristaloleg reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only 1 small doc fix.

stream.go Outdated Show resolved Hide resolved
@mr-linch @cristaloleg
Update stream.go
87a7360 
Co-authored-by: Oleg Kovalov <oleg@hey.com>
Signed-off-by: Sasha Savchuk <sasha@bots.house>
cristaloleg
cristaloleg approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cristaloleg cristaloleg merged commit 253c117 into cristalhq:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't close connection server-side
2 participants
@mr-linch @cristaloleg