Fix parsing media types with '.' in them #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC 2045[1]:
value := token / quoted-string
token := 1*<any (US-ASCII) CHAR except SPACE, CTLs,
or tspecials>
tspecials := "(" / ")" / "<" / ">" / "@" /
"," / ";" / ":" / "\" / <">
"/" / "[" / "]" / "?" / "="
; Must be in quoted-string,
; to use within parameter values
The RFC provides a good-list, while the code gives a bad-list. I didn't go
through the ASCII charset to check whether the two match up. I did notice
that '.' is missing though, because the azure.com API returns dots in
parameters.
[1]: https://www.ietf.org/rfc/rfc2045.txt
jnthn
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7 and #34
According to RFC 2045:
The RFC provides a good-list, while the code gives a bad-list. I didn't go
through the ASCII charset to check whether the two match up. I did notice
that '.' is missing though, because the azure.com API returns dots in
parameters.
RFC 6838 Allows the '.' as a char in parameter values just as well.