Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentatio for PR 156 #158

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add documentatio for PR 156 #158

merged 3 commits into from
Nov 10, 2023

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Nov 7, 2023

Add docs for @deprecated commends, introduced in #156

@a4z a4z requested a review from jothepro November 7, 2023 19:24
@a4z
Copy link
Contributor Author

a4z commented Nov 7, 2023

If possible, @eakoli please have a look
(I invited you into the github organization so I can request a review from you)

@a4z a4z requested a review from freitass November 9, 2023 21:51
freitass
freitass approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@freitass freitass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs!

docs/idl.md Outdated Show resolved Hide resolved
docs/idl.md Outdated Show resolved Hide resolved
jothepro
jothepro approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jothepro jothepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thx! :)

@a4z
Copy link
Contributor Author

a4z commented Nov 10, 2023

Thanks for the feedback! updated the unclear parts

@a4z a4z merged commit 202ad7c into cross-language-cpp:main Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freitass freitass freitass approved these changes

@jothepro jothepro jothepro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a4z @freitass @jothepro