Don't pause auto-tick unnecessarily in Optimize()

cross-platform · Jan 2, 2024 · 397acd4 · 397acd4
1 parent 5ef1331
commit 397acd4
Showing 1 changed file with 24 additions and 20 deletions.
diff --git a/src/Circuit.cpp b/src/Circuit.cpp
@@ -242,7 +242,10 @@ int Circuit::GetBufferCount() const
 
 void Circuit::Tick()
 {
-    p->Optimize();
+    if ( p->circuitDirty )
+    {
+        p->Optimize();
+    }
 
     // process in a single thread if this circuit has no threads
     // =========================================================
@@ -318,31 +321,32 @@ void Circuit::ResumeAutoTick()
 
 void Circuit::Optimize()
 {
-    PauseAutoTick();
-    p->Optimize();
-    ResumeAutoTick();
+    if ( p->circuitDirty )
+    {
+        PauseAutoTick();
+        p->Optimize();
+        ResumeAutoTick();
+    }
 }
 
 inline void internal::Circuit::Optimize()
 {
-    if ( circuitDirty )
-    {
-        std::vector<DSPatch::Component*> orderedComponents;
-        orderedComponents.reserve( components.size() );
+    std::vector<DSPatch::Component*> orderedComponents;
+    orderedComponents.reserve( components.size() );
 
-        for ( auto& component : components )
-        {
-            component->_Scan( orderedComponents );
-        }
+    // scan for optimal component order
+    for ( auto& component : components )
+    {
+        component->_Scan( orderedComponents );
+    }
 
-        // reset all internal components
-        for ( auto& component : components )
-        {
-            component->_EndScan();
-        }
+    // reset all isScanning flags
+    for ( auto& component : components )
+    {
+        component->_EndScan();
+    }
 
-        components = std::move( orderedComponents );
+    components = std::move( orderedComponents );
 
-        circuitDirty = false;
-    }
+    circuitDirty = false;
 }