fix: use .from instead

Signed-off-by: Tony Gorez <gorez.tony@gmail.com>
crossnx · Feb 21, 2024 · d8503df · d8503df
1 parent 1ef594d
commit d8503df
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/engine/include/includejs/engine_context.h b/src/engine/include/includejs/engine_context.h
@@ -21,7 +21,6 @@ class INCLUDEJS_ENGINE_EXPORT Context {
   ~Context();
 #endif
   auto make_undefined() const -> Value;
-  auto make_null() const -> Value;
   auto make_error(const std::string &message) const -> Value;
   auto make_object() const -> Value;
   auto make_promise() const -> Promise;

diff --git a/src/engine/javascript_core/engine_context.cc b/src/engine/javascript_core/engine_context.cc
@@ -29,10 +29,6 @@ auto Context::make_undefined() const -> Value {
           JSValueMakeUndefined(this->internal->context)};
 }
 
-auto Context::make_null() const -> Value {
-  return {this->internal->context, JSValueMakeNull(this->internal->context)};
-}
-
 auto Context::make_error(const std::string &message) const -> Value {
   JSStringRef message_value = JSStringCreateWithUTF8CString(message.c_str());
   JSValueRef error_arguments[]{
@@ -84,6 +80,10 @@ auto Context::from(const char *value) const -> Value {
   return {this->internal->context, result};
 }
 
+auto Context::from(std::nullptr_t) const -> Value {
+  return {this->internal->context, JSValueMakeNull(this->internal->context)};
+}
+
 auto Context::global() const -> Value {
   return {this->internal->context, this->internal->global};
 }

diff --git a/test/engine/engine_value_null_test.cc b/test/engine/engine_value_null_test.cc
@@ -5,7 +5,7 @@
 TEST(IncludeJS_Engine, create_null) {
   sourcemeta::includejs::Engine engine;
 
-  auto null = engine.context().make_null();
+  auto null = engine.context().from(nullptr);
   EXPECT_TRUE(null.is_null());
 }