-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a cross-engine WHATWG set of shims #22
Comments
Should this be directly in the example folder maybe? If we are a library that helps people write their runtime, I don't know if we should add more support for these APIs. Here are the two solutions that I see:
|
Ideas? @jviotti @thundron @bavulapati @RaisinTen |
Most of the WHATWG APIs are expected to be available in pretty much all JS runtimes, so I think it makes sense to implement those here. I can see how this can get tricky with stuff like |
yeah, it makes sense, but I wonder if someone wants to do its own implementation of timers for whatever reason, could we have a way to opt out? |
Yea, I think it makes total sense to allow customizations. 👍 |
Really like this :) |
I think we should have the shims at Pull in just the engine: find_package(IncludeJS COMPONENTS engine) Or the shims too: find_package(IncludeJS COMPONENTS engine whatwg) I then imagine the |
sounds like we probably want to define that interface as part of includejs and provide the mvp interface on top of appkit, win32 and glib? the only thing that is not clear to me here is how the integrating side would hook such an intermediate into it's own event loop. for the big toolkits mentioned above it might not be a hard requirement, but if an app drives it's own event loop with libuv for example they would have to be able to implement our dispatch interface or (ideally) plug in a libuv implementation we provide |
No description provided.
The text was updated successfully, but these errors were encountered: