Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module golang.org/x/crypto to v0.31.0 [SECURITY] #174

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
golang.org/x/crypto v0.21.0 -> v0.31.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-45337

Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.

The documentation for ServerConfig.PublicKeyCallback says that "A call to this function does not guarantee that the key offered is in fact used to authenticate." Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key. PublicKeyCallback may be called with multiple keys, and the order in which the keys were provided cannot be used to infer which key the client successfully authenticated with, if any. Some applications, which store the key(s) passed to PublicKeyCallback (or derived information) and make security relevant determinations based on it once the connection is established, may make incorrect assumptions.

For example, an attacker may send public keys A and B, and then authenticate with A. PublicKeyCallback would be called only twice, first with A and then with B. A vulnerable application may then make authorization decisions based on key B for which the attacker does not actually control the private key.

Since this API is widely misused, as a partial mitigation golang.org/x/crypto@v0.31.0 enforces the property that, when successfully authenticating via public key, the last key passed to ServerConfig.PublicKeyCallback will be the key used to authenticate the connection. PublicKeyCallback will now be called multiple times with the same key, if necessary. Note that the client may still not control the last key passed to PublicKeyCallback if the connection is then authenticated with a different method, such as PasswordCallback, KeyboardInteractiveCallback, or NoClientAuth.

Users should be using the Extensions field of the Permissions return value from the various authentication callbacks to record data associated with the authentication attempt instead of referencing external state. Once the connection is established the state corresponding to the successful authentication attempt can be retrieved via the ServerConn.Permissions field. Note that some third-party libraries misuse the Permissions type by sharing it across authentication attempts; users of third-party libraries should refer to the relevant projects for guidance.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Dec 16, 2024

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 6 additional dependencies were updated

Details:

Package Change
golang.org/x/mod v0.15.0 -> v0.17.0
golang.org/x/net v0.23.0 -> v0.25.0
golang.org/x/sys v0.20.0 -> v0.28.0
golang.org/x/term v0.18.0 -> v0.27.0
golang.org/x/text v0.14.0 -> v0.21.0
golang.org/x/tools v0.18.0 -> v0.21.1-0.20240508182429-e35e4ccd0d2d

@renovate renovate bot added the automated label Dec 16, 2024
@renovate renovate bot changed the title Update module golang.org/x/crypto to v0.31.0 [SECURITY] Update module golang.org/x/crypto to v0.31.0 [SECURITY] - autoclosed Dec 17, 2024
@renovate renovate bot closed this Dec 17, 2024
@renovate renovate bot deleted the renovate/go-golang.org-x-crypto-vulnerability branch December 17, 2024 13:41
@renovate renovate bot changed the title Update module golang.org/x/crypto to v0.31.0 [SECURITY] - autoclosed Update module golang.org/x/crypto to v0.31.0 [SECURITY] Dec 17, 2024
@renovate renovate bot reopened this Dec 17, 2024
@renovate renovate bot force-pushed the renovate/go-golang.org-x-crypto-vulnerability branch from 5d0da2b to c254582 Compare December 17, 2024 17:30
@turkenf
Copy link
Collaborator

turkenf commented Dec 19, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

@turkenf turkenf merged commit 5c44b3a into main Dec 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant