Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standalone crddiff tool #165

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Oct 31, 2024

Description of your changes

This PR uses the standalone crddiff tool.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with the uptest in the below comments.

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 31, 2024

/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 31, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 31, 2024

/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 31, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

@turkenf turkenf changed the title Bump uptest version to v0.13.0 and use crddiff tool Use standalone crddiff tool Oct 31, 2024
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Oct 31, 2024

/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml"

https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/11616369681

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 31, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/11616370685

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf 🙌 LGTM. For posterity, crddiff used to be a command-line argument to uptest. crddiff didn't fit uptest's purpose in the first place, so it was removed before donating uptest to the community. Now that we have updated the build module to use crossplane/build, which doesn't have crddiff, we are running it from upbound/uptest.

@turkenf turkenf merged commit d04c5d6 into crossplane-contrib:main Oct 31, 2024
11 checks passed
@turkenf turkenf deleted the bump-uptest branch October 31, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants