Add an event filter with the resource.DesiredStateChanged predicate to filter status updates out #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/applications/application.yaml" |
|
/test-examples="examples/applications/application.yaml" |
|
/test-examples="examples/applications/application.yaml" |
…o filter status updates out - Support Granular management policies - Explicitly queue a reconcile request if a shared provider has expired Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/applications/application.yaml" |
turkenf
pushed a commit
that referenced
this pull request
Aug 4, 2023
Add an event filter with the resource.DesiredStateChanged predicate to filter status updates out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on: crossplane/upjet#241
This PR adds an event filter using the resource.DesiredStateChanged to the generated resource controllers so that updates to only labels, annotations (Crossplane's create pending/failed annotations will be ignored) and to the
specwill result in reconcile requests. The relevant upjet PR is crossplane/upjet#231.It also adds support for granular management policies and the
spec.initProviderAPI to allow the specification of the configuration parameters that will only be used during a create call. Please refer to the relevant upjet PRs: crossplane/upjet#224, crossplane/upjet#237It also introduces a change in the external client that reconciles the MRs of this provider so that the external client now explicitly re-queues a reconcile request if a shared provider has expired. Please refer to the relevant upjet PR for more details: crossplane/upjet#241
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Please see crossplane-contrib/provider-upjet-aws#805 and crossplane/upjet#231 (comment) for tests related to the changes introduced here.
With @turkenf, we have also (re)tested the granular management policies alpha feature.