Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Terraform Plugin SDK to Reconcile MRs #86

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Use Terraform Plugin SDK to Reconcile MRs #86

merged 5 commits into from
Nov 29, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Nov 22, 2023 •
edited by turkenf
Loading

Description of your changes

This PR employs the controller.noForkExternal & controller.noForkAsyncExternal external clients from upjet to reconcile MRs without forking any Terraform CLI or Terraform provider processes.

Some more details on these clients can be found here.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Successful runes of the resources tested with Uptest have been added to the comments below.

Manual tests:

  • Member.administrativeunits
status:
  atProvider:
    administrativeUnitObjectId: 0ae302dc-49fe-445e-b2d1-e0e5448d2e7c
    id: 0ae302dc-49fe-445e-b2d1-e0e5448d2e7c/member/3f061130-d036-4461-8c3e-76a08aabfd08
    memberObjectId: 3f061130-d036-4461-8c3e-76a08aabfd08
  conditions:
  - lastTransitionTime: "2023-11-28T11:17:33Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-11-28T11:17:33Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation
  - lastTransitionTime: "2023-11-28T11:17:33Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2023-11-28T11:20:57Z"
    reason: UpToDate
    status: "True"
    type: Test
  • Invitation.invitations

Administrator-level permissions are required to test this resource. As far as I understand, I cannot test this resource due to changes made in the organization. But I get the same error in the Azure console as I get in the terminal.

@ulucinar ulucinar marked this pull request as draft November 22, 2023 09:21
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/applications/application.yaml"

@ulucinar ulucinar mentioned this pull request Nov 22, 2023
Merged
1 task
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/applications/application.yaml"

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/applications/application.yaml"

@ulucinar
Copy link
Collaborator Author

ulucinar commented Nov 22, 2023 •
edited by turkenf
Loading

/test-examples="examples/applications/application.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6956561752

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2023 •
edited
Loading

/test-examples="examples/administrativeunits/unit.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6956752851

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2023 •
edited
Loading

/test-examples="examples/app/roleassignment.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6956764796

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2023 •
edited
Loading

/test-examples="examples/applications/certificate.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6956772090

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2023 •
edited
Loading

/test-examples="examples/applications/federatedidentitycredential.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6957674363

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2023 •
edited
Loading

/test-examples="examples/applications/password.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6957683486

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2023 •
edited
Loading

/test-examples="examples/applications/preauthorized.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6957690956

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/conditionalaccess/location.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6965997159

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/conditionalaccess/accesspolicy.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966020106

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/directoryroles/customdirectoryrole.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966039641

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/directoryroles/role.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966040449

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/directoryroles/roleassignment.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966041347

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/groups/member.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966054928

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/policies/claimsmappingpolicy.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966150645

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/serviceprincipaldelegated/permissiongrant.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966168432

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/serviceprincipals/password.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966189260

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/serviceprincipals/principal.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966199602

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/serviceprincipals/certificate.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966201847

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/serviceprincipals/claimsmappingpolicyassignment.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966204746

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/serviceprincipals/tokensigningcertificate.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966215562

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/synchronization/job.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966228585

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/synchronization/secret.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966233178

@turkenf
Copy link
Collaborator

turkenf commented Nov 23, 2023 •
edited
Loading

/test-examples="examples/users/user.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/6966237612

@turkenf
Copy link
Collaborator

turkenf commented Nov 28, 2023 •
edited
Loading

/test-examples="examples/groups/group.yaml"

Uptest run: https://github.com/upbound/provider-azuread/actions/runs/7017577940

@ulucinar
Copy link
Collaborator Author

The external-name configuration for the untested Invitation.invitation resource is config.IdentifierFromProvider. So the risk of breaking this resource with the arch. change is low. I think we are good to go.

turkenf
turkenf reviewed Nov 29, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ulucinar ulucinar marked this pull request as ready for review November 29, 2023 11:52
@ulucinar
Switch to the no-fork architecture for the Google resources
aaf166f 
- Bump upjet to v1.0.0

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Run "make generate"
2e5443e 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Bump Go version to 1.21
750310d 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Bump Go version to 1.21 in go.mod
30627d6 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Remove the call to rand.Seed as it's no longer needed with Go >=1.20
5ed2447 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/application.yaml"

turkenf
turkenf approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar, LGTM.

@ulucinar ulucinar merged commit e5e940c into crossplane-contrib:main Nov 29, 2023
10 checks passed
@ulucinar ulucinar deleted the no-fork-v2.41.0 branch November 29, 2023 12:51
@ulucinar ulucinar mentioned this pull request Nov 29, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenf turkenf turkenf approved these changes

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulucinar @turkenf