-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Terraform CLI from the provider package #89
Conversation
/test-examples="examples/applications/application.yaml" |
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
0ff8e4b
to
48fe511
Compare
/test-examples="examples/applications/application.yaml" |
/test-examples="examples/administrativeunits/unit.yaml" |
/test-examples="examples/conditionalaccess/accesspolicy.yaml" |
/test-examples="examples/directoryroles/customdirectoryrole.yaml" |
/test-examples="examples/groups/member.yaml" |
/test-examples="examples/serviceprincipaldelegated/permissiongrant.yaml" |
/test-examples="examples/serviceprincipals/principal.yaml" |
/test-examples="examples/synchronization/job.yaml" |
/test-examples="examples/applications/certificate.yaml" |
/test-examples="examples/applications/federatedidentitycredential.yaml" |
/test-examples="examples/applications/password.yaml" |
/test-examples="examples/applications/preauthorized.yaml" |
/test-examples="examples/conditionalaccess/location.yaml" |
/test-examples="examples/directoryroles/role.yaml" |
/test-examples="examples/directoryroles/roleassignment.yaml" |
/test-examples="examples/groups/group.yaml" |
/test-examples="examples/policies/claimsmappingpolicy.yaml" |
/test-examples="examples/serviceprincipals/password.yaml" |
/test-examples="examples/serviceprincipals/certificate.yaml" |
/test-examples="examples/serviceprincipals/claimsmappingpolicyassignment.yaml" |
/test-examples="examples/serviceprincipals/tokensigningcertificate.yaml" |
/test-examples="examples/synchronization/secret.yaml" |
/test-examples="examples/users/user.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ulucinar, LGTM.
Description of your changes
With #86, we have switched to the Terraform plugin SDK-based reconciliation for all the available managed resources in this provider. This PR removes the Terraform CLI and the Terraform AzureAD provider binaries from the built provider package. We still need to generate the
config/schema.json
for diff detection purposes and we are planning to address the issue of generating theschema.json
without the TF CLI in a follow-up PR.We may consider keeping the Crossplane provider command-line args intact (but deprecate them) to prevent any breaking changes.
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Via the uptest runs below and manually via the package
index.docker.io/ulucinar/provider-azuread:v0.14.0-48fe511f83b394ef64a97487fd330f782f4a82e3
built from this PR.