Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Terraform CLI from the provider package #89

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Nov 29, 2023

Description of your changes

With #86, we have switched to the Terraform plugin SDK-based reconciliation for all the available managed resources in this provider. This PR removes the Terraform CLI and the Terraform AzureAD provider binaries from the built provider package. We still need to generate the config/schema.json for diff detection purposes and we are planning to address the issue of generating the schema.json without the TF CLI in a follow-up PR.

We may consider keeping the Crossplane provider command-line args intact (but deprecate them) to prevent any breaking changes.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Via the uptest runs below and manually via the package index.docker.io/ulucinar/provider-azuread:v0.14.0-48fe511f83b394ef64a97487fd330f782f4a82e3 built from this PR.

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/application.yaml"

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/application.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/administrativeunits/unit.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/conditionalaccess/accesspolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/directoryroles/customdirectoryrole.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/groups/member.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/serviceprincipaldelegated/permissiongrant.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/serviceprincipals/principal.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/synchronization/job.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/certificate.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/federatedidentitycredential.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/password.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/applications/preauthorized.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/conditionalaccess/location.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/directoryroles/role.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/directoryroles/roleassignment.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/groups/group.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/policies/claimsmappingpolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/serviceprincipals/password.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/serviceprincipals/certificate.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/serviceprincipals/claimsmappingpolicyassignment.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/serviceprincipals/tokensigningcertificate.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/synchronization/secret.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 29, 2023

/test-examples="examples/users/user.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar, LGTM.

@ulucinar ulucinar merged commit 7e8a41c into crossplane-contrib:main Nov 29, 2023
32 checks passed
@ulucinar ulucinar deleted the remove-tf-cli branch November 29, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants