Deprecate process-fork related command-line flags #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/applications/application.yaml" |
- terraform-version - terraform-provider-version - terraform-native-provider-path - terraform-provider-source - provider-ttl Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
deprecate-process-args
branch
from
9870a83
to
c5866ef
Compare
|
/test-examples="examples/applications/application.yaml" |
|
We also need to communicate this in our release notes. cc. @turkenf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We are deprecating the following process-forking related command-line arguments:
What the user will see in the provider logs if she uses any of these flags is something like the following:
These logs will be available even if the the
debuglogging is not enabled for the provider.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested manually via
index.docker.io/ulucinar/provider-azuread:v0.14.0-c5866ef3f94acdd1d8cba067906191017eff701band via uptest in https://github.com/upbound/provider-azuread/actions/runs/7035191432.