-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adler32 string transform implementation #4417
Conversation
}, | ||
want: want{ | ||
o: "471008351", | ||
//o: "373097499", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the right value once we get #4445 merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to update it to the correct value after rebasing on #4445.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to update the docs as well, pushing a PR against https://github.com/crossplane/docs/
Looks like there are conflicts, @stevendborrelli, could you rebase and address the comment from @pedjak about the doc, we actually added a check to the PRs checklist for that now too 🙏 |
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
ae75187
to
2557cf0
Compare
Pull request has been rebased off of #4445 and the test hashes have been updated to correct values. |
Docs PR created: crossplane/docs#524 |
Description of your changes
Adds an Adler-32 checksum, this is used with some Let's Encrypt configurations.
Testing:
I tested the hashing using the following Python script, these values matched the values generated by the transform.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.