Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web Bug] - AWS Quickstart Part 2 - should the patches be the same? #550

Closed
jbw976 opened this issue Sep 17, 2023 · 1 comment
Closed

[Web Bug] - AWS Quickstart Part 2 - should the patches be the same? #550

jbw976 opened this issue Sep 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jbw976
Copy link
Member

jbw976 commented Sep 17, 2023

The example Composition manifest in https://docs.crossplane.io/v1.13/getting-started/provider-aws-part-2/#create-a-deployment-template has 2 similar patches for the bucket and the dynamodb table. The one for the bucket uses location and the one for table uses spec.location.

I suspect though that they should actually both use spec.location given the XRD defined in https://docs.crossplane.io/v1.13/getting-started/provider-aws-part-2/#apply-the-api.

bucket:

patches:
  - type: FromCompositeFieldPath
    fromFieldPath: "location"
    toFieldPath: "spec.forProvider.region"

table:

patches:
  - type: FromCompositeFieldPath
    fromFieldPath: "spec.location"
    toFieldPath: "spec.forProvider.region"

URL: https://docs.crossplane.io/v1.13/getting-started/provider-aws-part-2/

@jbw976 jbw976 added the bug Something isn't working label Sep 17, 2023
@jbw976 jbw976 changed the title [Web Bug] - AWS Quickstart Part 2 [Web Bug] - AWS Quickstart Part 2 - should the patches be the same? Sep 17, 2023
@plumbis
Copy link
Collaborator

plumbis commented Sep 19, 2023

Fixed with #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants