Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mermaid doesn't update when color mode changed #592

Closed
plumbis opened this issue Oct 30, 2023 · 0 comments · Fixed by #718
Closed

Mermaid doesn't update when color mode changed #592

plumbis opened this issue Oct 30, 2023 · 0 comments · Fixed by #718
Labels
bug Something isn't working P2 Should fix, important issues. Some user impact

Comments

@plumbis
Copy link
Collaborator

plumbis commented Oct 30, 2023

What's Wrong?

The mermaid diagram code introduced in #583 doesn't update the diagram colors when someone clicks the color theme switcher. Let's fix it.
@plumbis plumbis added bug Something isn't working P2 Should fix, important issues. Some user impact labels Oct 30, 2023
plumbis added a commit to plumbis/crossplane-docs that referenced this issue Feb 16, 2024
@plumbis
add styling to mermaid diagrams for dark/light mode. Resolves crosspl…
1ecb3c1 
…ane#592

Signed-off-by: Pete Lumbis <pete@upbound.io>
@plumbis plumbis mentioned this issue Feb 16, 2024
Merged
plumbis added a commit that referenced this issue Feb 16, 2024
@plumbis
Fix mermaid diagrams in light/dark mode (#718)
83a3d08 
* add mermaid sheets

Signed-off-by: Pete Lumbis <pete@upbound.io>

* add styling to mermaid diagrams for dark/light mode. Resolves #592

Signed-off-by: Pete Lumbis <pete@upbound.io>

---------

Signed-off-by: Pete Lumbis <pete@upbound.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 Should fix, important issues. Some user impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mermaid diagrams in light/dark mode plumbis/crossplane-docs
1 participant
@plumbis