-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document MatchTrue, MatchFalse and MatchCondition readiness checks #513
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you so much for the docs PR! A few nits to improve wording and pass Vale CI checks.
Ah thank you @plumbis, that's my bad, I forgot to run the checks locally 😅 I'll commit fixes shortly. |
@LCaparelli, gentle reminder 😅 |
Thanks hehe, just got back from vacation and this one escaped my final wrapping up process before disappearing 😁 |
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Co-authored-by: Pete Lumbis <pete@upbound.io> Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Companion for crossplane/crossplane#4399
I noticed MatchCondition was not yet documented. If this was intentional or if you'd rather it in a separate PR just let me know :-)