Minor color improvements #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shanecmiller23
commented
Aug 8, 2023
•
shanecmiller23
commented
- Improve contrast for accordions/expandable blocks
- Improve coloring for "Join the Crossplane Slack" home page tooltip
- Replaced all old color variables with the new palette variables
- Fix dark mode coloring for vertical striped tables
- Remove table aqua background hover states
Signed-off-by: Shane Miller <shanecm.ux@gmail.com>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@jbw976 per some of your recent feedback, darkened the borders/icons for these components |
Signed-off-by: Shane Miller <shanecm.ux@gmail.com>
shanecmiller23
changed the title
Signed-off-by: Shane Miller <shanecm.ux@gmail.com>
shanecmiller23
changed the title
jbw976
reviewed
Aug 8, 2023
| @@ -51,7 +51,7 @@ | |||
|
|
|||
| // Override Bootstrap accordion colors in the body | |||
| .accordion { | |||
| --bs-accordion-border-color: #{$fog-800}; | |||
| --bs-accordion-border-color: #{$fog-500}; | |||
There was a problem hiding this comment.
There's something fishy going on with the bottom rounded corners of the accordions when they are in their expanded state - looks like it's still a dark color that doesn't match the straight line edge borders, or they are clipped or something? they look like they are missing essentially - do you see this too?
e.g. on https://deploy-preview-522--crossplane.netlify.app/v1.13/concepts/compositions/
There was a problem hiding this comment.
I see the same thing in dark mode.
Signed-off-by: Shane Miller <shanecm.ux@gmail.com>
Signed-off-by: Shane Miller <shanecm.ux@gmail.com>
plumbis
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.