-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the ControllerConfig deprecation warning #548
Updates the ControllerConfig deprecation warning #548
Conversation
It now includes a link to the replacement solution design. Signed-off-by: Jean du Plessis <jean@upbound.io>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
### Controller configuration | ||
|
||
{{< hint "important" >}} | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
Applying a Controller configuration generates a deprecation warning. | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
indicate that no further enhancements will be made to it. | ||
Applying a Controller configuration generates a deprecation warning. | ||
|
||
Controller configurations are still supported until there is a replacement type | ||
in a future Crossplane version. | ||
in a future Crossplane version. You can read more about the design of | ||
[Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
which will replace it in the future. | ||
|
||
{{< /hint >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant section for review
### Controller configuration | ||
|
||
{{< hint "important" >}} | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
Applying a Controller configuration generates a deprecation warning. | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
indicate that no further enhancements will be made to it. | ||
Applying a Controller configuration generates a deprecation warning. | ||
|
||
Controller configurations are still supported until there is a replacement type | ||
in a future Crossplane version. | ||
in a future Crossplane version. You can read more about the design of | ||
[Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
which will replace it in the future. | ||
{{< /hint >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant section for review
### Controller configuration | ||
|
||
{{< hint "important" >}} | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
Applying a Controller configuration generates a deprecation warning. | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
indicate that no further enhancements will be made to it. | ||
Applying a Controller configuration generates a deprecation warning. | ||
|
||
Controller configurations are still supported until there is a replacement type | ||
in a future Crossplane version. | ||
in a future Crossplane version. You can read more about the design of | ||
[Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
which will replace it in the future. | ||
{{< /hint >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant section for review
### Controller configuration | ||
|
||
{{< hint "important" >}} | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11. | ||
Applying a Controller configuration generates a deprecation warning. | ||
The Crossplane community deprecated the `ControllerConfig` type in v1.11 to | ||
indicate that no further enhancements will be made to it. | ||
Applying a Controller configuration generates a deprecation warning. | ||
|
||
Controller configurations are still supported until there is a replacement type | ||
in a future Crossplane version. | ||
in a future Crossplane version. You can read more about the design of | ||
[Package Runtime Config](https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md) | ||
which will replace it in the future. | ||
{{< /hint >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the relevant section for review
It now includes a link to the replacement solution design.
Urgh... unfortunately my document formatter removed all trailing space so there's a lot of noise in this diff. The relevant diff lines are 309:318