Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Helm chart values table from crossplane/crossplane repo #572

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Oct 18, 2023

This PR updates the table of Helm chart values to match the latest in https://github.com/crossplane/crossplane/blob/master/cluster/charts/crossplane/README.md.

This was spurred by crossplane/crossplane#4831 where the default value for image.repository is changing, but I noticed a lot of other differences from crossplane/crossplane that hadn't made their way over to the docs, so I just copied the whole thing over in its entirety.

The history of recent changes to the helm chart readme in crossplane can be found at https://github.com/crossplane/crossplane/commits/master/cluster/charts/crossplane/README.md for curious reviewers.

Is there an process that could be in place to ensure the two stay in sync? 🤔

Affected page in the deployment preview (don't forget to expand the accordion!): https://deploy-preview-572--crossplane.netlify.app/master/software/install/#customize-the-crossplane-helm-chart

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 7f8ab8d
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/6530671a5c6566000799bda2
😎 Deploy Preview https://deploy-preview-572--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@plumbis plumbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maximize annoyances this fails Vale checking because we made vale do it's job better since the last time this was synced.

I opened crossplane/crossplane#4840 to put the fixes in the Crossplane templates.

Can you re copy/pasta and Vale should pass and I'll approve.

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
Copy link
Member Author

jbw976 commented Oct 18, 2023

Your PR crossplane/crossplane#4841 has been merged @plumbis, so I copied over the latest from crossplane master and included it in this PR ✅

@plumbis plumbis merged commit 7eca790 into crossplane:master Oct 20, 2023
7 checks passed
plumbis pushed a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants