-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrects usage of Trim Prefix/Suffix. #748
Conversation
Signed-off-by: Pete Lumbis <pete@upbound.io>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be fixed in master
too?
https://github.com/crossplane/docs/blob/master/content/master/concepts/patch-and-transform.md
Signed-off-by: Pete Lumbis <pete@upbound.io>
🤦♂️ I fixed it and forgot to add it to the commit. Done. |
The {{<hover label="typeRegex" line="8">}}type: TrimSuffix{{</hover>}} removes | ||
the matching string and all proceeding characters. | ||
The {{<hover label="typeTrimS" line="8">}}type: TrimSuffix{{</hover>}} uses | ||
Go's [TrimSuffix](https://pkg.go.dev/strings#TrimPrefix) and removes characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should link to the TrimSuffix function - i think this problem exists for all versions
Signed-off-by: Pete Lumbis <pete@upbound.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for the link on the v1.13 page 🙏
Signed-off-by: Pete Lumbis <pete@upbound.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, looks good to me now @plumbis!! 💪
Resolves #747