-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove knowledge base section #755
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clicked through basically everything (including all the redirects) and this is looking good to me! I think it's a much more cohesive navigation experience to keep the left hand navigation pane mostly static. Really like this improvement!! 🙇♂️
# Moved KB article. See issue #749 | ||
from = "/knowledge-base/guides/composition-revisions" | ||
to = "/latest/concepts/composition-revisions/" | ||
status = 301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
301 redirects sound like the right thing to do here, e.g. permanent redirect, but did want to call out that the previous pattern had been 302. Not sure if that divergence was intentional, but 301 does sound correct to me here.
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Signed-off-by: Pete Lumbis <pete@upbound.io>
Related discussion in #749.
/latest
version. - https://deploy-preview-755--crossplane.netlify.app//knowledge-base
section and reorganizes pages into/concepts
,/guides
(new), or/learn
(new) sections./knowledge-base/*
pathsBelow is a list of all KB pages to verify their redirects inside Netlify.
I've also manually searched all pages to find KB and docs.crossplane links and update them. We're passing hugo build and the
htmltest
CI check, so I feel confident we've covered all existing KB links.Verified redirects:
https://deploy-preview-755--crossplane.netlify.app/knowledge-base
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/disaster-recovery/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/connection-details/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/write-a-composition-function-in-go/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/write-a-composition-function-in-python/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/import-existing-resources/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/multi-tenant/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/self-signed-ca-certs/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/troubleshoot/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/learn-more/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/release-cycle/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/feature-lifecycle/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/composition-revisions-example/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/guides/composition-revisions/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/integrations/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/integrations/vault-as-secret-store/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/integrations/vault-injection/
https://deploy-preview-755--crossplane.netlify.app/knowledge-base/integrations/argo-cd-crossplane/