-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.16 Docs #773
v1.16 Docs #773
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you for taking this on @tr0njavolta! Does this address everything in #772, or a subset of that checklist? I'll start taking a deeper pass through now, including checking out the preview site to make sure functionality looks to be in the right place 😉
@jbw976 updated with the checklist and verified with the preview. API/CRD updates look good and version changes are in the right place. The Vale issues I can tackle in a separate PR because that content was already present so there's probably a rule not applied in the new version that I can check out. |
I don't see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly pretty good here @tr0njavolta!! a couple questions included :)
Looks like the latest commit didn't have a sign-off, so the DCO check is failing: https://github.com/crossplane/docs/pull/773/checks?check_run_id=25023037420 Can you fix that up please? 🙏 this link may help: https://github.com/crossplane/crossplane/tree/master/contributing#certificate-of-origin |
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
This was a blocker for @tr0njavolta because they didn't have permissions to create a new release/tag in the Github UI. I created the release/tag at https://github.com/crossplane/docs/releases/tag/v1.13-archive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I think we've resolved everything in this PR now, looks good to me @tr0njavolta! thank you for your work on this docs release!!
I'll approve now, but then merge this when I'm ready with the rest of the v1.16 release process so they stay in sync: crossplane/release#9
#772
Updates master with version 1.16