Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.16 Docs #773

Merged
merged 3 commits into from
May 16, 2024
Merged

v1.16 Docs #773

merged 3 commits into from
May 16, 2024

Conversation

tr0njavolta
Copy link
Contributor

@tr0njavolta tr0njavolta commented May 15, 2024

#772

Updates master with version 1.16

  • Update the $LATEST_VER parameter in netlify_build.sh
  • Update params.latest in config.yaml
  • Update version in the _index.md file of /content/ from master to the correct version.
  • Copy Crossplane cluster/crds contents to /content//api/crds.
  • Create a new release/tag named "v-archive" to snapshot EOL'd docs.
  • Remove EOL'd docs version from "/content" directory and run hugo locally to check for broken links.
  • Trigger Algolia Crawler after publishing to reindex results.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit b4b9960
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/6645287ec6ec290008dbf251
😎 Deploy Preview https://deploy-preview-773--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 1 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tr0njavolta tr0njavolta changed the title version update v1.16 Docs May 15, 2024
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you for taking this on @tr0njavolta! Does this address everything in #772, or a subset of that checklist? I'll start taking a deeper pass through now, including checking out the preview site to make sure functionality looks to be in the right place 😉

@tr0njavolta
Copy link
Contributor Author

Awesome thank you for taking this on @tr0njavolta! Does this address everything in #772, or a subset of that checklist? I'll start taking a deeper pass through now, including checking out the preview site to make sure functionality looks to be in the right place 😉

@jbw976 updated with the checklist and verified with the preview. API/CRD updates look good and version changes are in the right place.

The Vale issues I can tackle in a separate PR because that content was already present so there's probably a rule not applied in the new version that I can check out.

@jbw976
Copy link
Member

jbw976 commented May 15, 2024

Create a new release/tag named "v-archive" to snapshot EOL'd docs.

I don't see the v1.13-archive release/tag yet - do you? 🤔

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly pretty good here @tr0njavolta!! a couple questions included :)

content/v1.13/concepts/composition-functions.md Outdated Show resolved Hide resolved
content/v1.15/guides/import-existing-resources.md Outdated Show resolved Hide resolved
content/v1.15/guides/import-existing-resources.md Outdated Show resolved Hide resolved
@jbw976
Copy link
Member

jbw976 commented May 15, 2024

Looks like the latest commit didn't have a sign-off, so the DCO check is failing: https://github.com/crossplane/docs/pull/773/checks?check_run_id=25023037420

Can you fix that up please? 🙏 this link may help: https://github.com/crossplane/crossplane/tree/master/contributing#certificate-of-origin

Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
@jbw976
Copy link
Member

jbw976 commented May 15, 2024

I don't see the v1.13-archive release/tag yet - do you? 🤔

This was a blocker for @tr0njavolta because they didn't have permissions to create a new release/tag in the Github UI. I created the release/tag at https://github.com/crossplane/docs/releases/tag/v1.13-archive

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I think we've resolved everything in this PR now, looks good to me @tr0njavolta! thank you for your work on this docs release!!

I'll approve now, but then merge this when I'm ready with the rest of the v1.16 release process so they stay in sync: crossplane/release#9

@jbw976 jbw976 merged commit 438cf50 into crossplane:master May 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants