-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.17 Docs #804
v1.17 Docs #804
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bc136d0
to
12ddd8e
Compare
Not sure why the Vale check here was a problem compared to v1.16. I don't recall that many errors throwing from moving content around. |
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
9fbde7b
to
0c202ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have some investigation to do to understand why it looks like removed content is getting added back in here. Please take a look when you can @tr0njavolta! 🙇♂️
* [**Composition Functions**]({{<ref "./composition-functions">}}) are custom | ||
programs, written your programming language of choice, to apply logic and | ||
loops before or after Crossplane creates resources. | ||
|
||
* [**Patches and Transforms**]({{<ref "./patch-and-transform">}}) allow platform | ||
engineers to use user inputs to their custom API and change how Crossplane | ||
creates resources. Patches and transforms allow for flexible and | ||
abstract inputs like `big` or `encrypted` to have specific meanings when | ||
creating the actual managed resources. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content was removed in https://github.com/crossplane/docs/pull/799/files#diff-b256b27bd644a45659738110dfece51b3c4961f7ca2cdf9913524c04b0a54623 with @negz's big PR to make docs "functions first".
Do we understand how this is getting added back in here? I'm concerned about the validity of the other changes in this massive PR if it's accidentally restoring content that was intentionally removed...can we get to the bottom of this? 🙏
* [**Composition Functions**]({{<ref "./composition-functions">}}) are custom | ||
programs, written your programming language of choice, to apply logic and | ||
loops before or after Crossplane creates resources. | ||
|
||
* [**Patches and Transforms**]({{<ref "./patch-and-transform">}}) allow platform | ||
engineers to use user inputs to their custom API and change how Crossplane | ||
creates resources. Patches and transforms allow for flexible and | ||
abstract inputs like `big` or `encrypted` to have specific meanings when | ||
creating the actual managed resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment as #804 (comment) here too - this shouldn't be in the master
content nor should it be in the v1.17
content since it was removed in https://github.com/crossplane/docs/pull/799/files#diff-b256b27bd644a45659738110dfece51b3c4961f7ca2cdf9913524c04b0a54623. This may be pervasive across multiple areas in both master
and v1.17
🤔
No description provided.