Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17 Docs #804

Closed
wants to merge 4 commits into from
Closed

v1.17 Docs #804

wants to merge 4 commits into from

Conversation

tr0njavolta
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 0c202ca
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/66cf9b9288a21b0008c08211
😎 Deploy Preview https://deploy-preview-804--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 3 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tr0njavolta tr0njavolta force-pushed the v117-update branch 2 times, most recently from bc136d0 to 12ddd8e Compare August 28, 2024 21:28
@tr0njavolta tr0njavolta changed the title Release v1.17 v1.17 Docs Aug 28, 2024
@tr0njavolta
Copy link
Contributor Author

Not sure why the Vale check here was a problem compared to v1.16. I don't recall that many errors throwing from moving content around.

content/master/_index.md Outdated Show resolved Hide resolved
content/master/_index.md Outdated Show resolved Hide resolved
tr0njavolta and others added 4 commits August 28, 2024 17:50
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Signed-off-by: Sharp <rachel.sharp@upbound.io>
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have some investigation to do to understand why it looks like removed content is getting added back in here. Please take a look when you can @tr0njavolta! 🙇‍♂️

Comment on lines +58 to +67
* [**Composition Functions**]({{<ref "./composition-functions">}}) are custom
programs, written your programming language of choice, to apply logic and
loops before or after Crossplane creates resources.

* [**Patches and Transforms**]({{<ref "./patch-and-transform">}}) allow platform
engineers to use user inputs to their custom API and change how Crossplane
creates resources. Patches and transforms allow for flexible and
abstract inputs like `big` or `encrypted` to have specific meanings when
creating the actual managed resources.

Copy link
Member

@jbw976 jbw976 Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content was removed in https://github.com/crossplane/docs/pull/799/files#diff-b256b27bd644a45659738110dfece51b3c4961f7ca2cdf9913524c04b0a54623 with @negz's big PR to make docs "functions first".

Do we understand how this is getting added back in here? I'm concerned about the validity of the other changes in this massive PR if it's accidentally restoring content that was intentionally removed...can we get to the bottom of this? 🙏

Comment on lines +58 to +66
* [**Composition Functions**]({{<ref "./composition-functions">}}) are custom
programs, written your programming language of choice, to apply logic and
loops before or after Crossplane creates resources.

* [**Patches and Transforms**]({{<ref "./patch-and-transform">}}) allow platform
engineers to use user inputs to their custom API and change how Crossplane
creates resources. Patches and transforms allow for flexible and
abstract inputs like `big` or `encrypted` to have specific meanings when
creating the actual managed resources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as #804 (comment) here too - this shouldn't be in the master content nor should it be in the v1.17 content since it was removed in https://github.com/crossplane/docs/pull/799/files#diff-b256b27bd644a45659738110dfece51b3c4961f7ca2cdf9913524c04b0a54623. This may be pervasive across multiple areas in both master and v1.17 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants