A few grammatical updates #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jbw976
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
nice @olearycrew, thanks for making these updates! They all seem reasonable enough to me.
I think we just need a DCO sign-off for your commit, here's info on that from the contributing guide: https://github.com/crossplane/crossplane/tree/main/contributing#certificate-of-origin
| @@ -437,7 +437,7 @@ Including YAML files that aren't Compositions or CompositeResourceDefinitions, | |||
| including Claims isn't supported. | |||
| {{</hint >}} | |||
|
|
|||
| By default, Crossplane creates an `.xpkg` file of the Configuration name and | |||
| By default, Crossplane creates a `.xpkg` file of the Configuration name and | |||
There was a problem hiding this comment.
i didn't think this was right at first, but I guess it does actually work because it should be read as creates a dot xpkg file
Signed-off-by: Brendan O'Leary <brendan@olearycrew.com>
olearycrew
force-pushed
the
olearycrew-grammar-fixes
branch
from
63ce627
to
076d4ac
Compare
|
@jbw976 sorry I missed the DCO - signed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.