Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Expo SDK 48 #365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support for Expo SDK 48 #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad9e84a
Update AppDelegate header injection pattern for Expo 48
rightones Feb 12, 2023
f404424
Update default Kotlin version for Expo 48
rightones Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/android/withAndroidKakaoLogin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const modifyProjectBuildGradle: ConfigPlugin<KakaoLoginPluginProps> = (
AndroidConfig.BuildProperties.updateAndroidBuildProperty(
config.modResults,
'android.kotlinVersion',
props.kotlinVersion ?? '1.5.10',
props.kotlinVersion ?? '1.5.20',
);

return config;
Expand All @@ -113,7 +113,7 @@ const modifyProjectBuildGradle: ConfigPlugin<KakaoLoginPluginProps> = (
/dependencies\s?{/,
`dependencies {
classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:${
props.kotlinVersion ?? '1.5.10'
props.kotlinVersion ?? '1.5.20'
}'`,
);
}
Expand Down
8 changes: 4 additions & 4 deletions plugins/ios/withIosKakaoLogin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ const modifyAppDelegate: ConfigPlugin = (config) => {
const modifyContents = (contents: string): string => {
if (!contents.includes(KAKAO_HEADER_IMPORT_STRING)) {
contents = contents.replace(
'#if',
`
${KAKAO_HEADER_IMPORT_STRING}
#if`,
"@implementation AppDelegate",
`${KAKAO_HEADER_IMPORT_STRING}

@implementation AppDelegate`
Comment on lines +99 to +100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation does not look correct here!

);
}

Expand Down