Skip to content

Commit

Permalink
Include dds modules in image
Browse files Browse the repository at this point in the history
  • Loading branch information
crschnick committed Jun 22, 2023
1 parent b500c77 commit b45f11b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions gradle/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ jlink {
'jdk.crypto.ec',
'org.kordamp.ikonli.materialdesign',
'jdk.zipfs',
'io.github.ititus.dds',
'io.github.ititus.ddsiio',
'jdk.accessibility'
]
}
Expand Down
1 change: 0 additions & 1 deletion pdxu-app/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
requires javafx.controls;
requires javafx.media;
requires info.picocli;
requires io.github.ititus.dds;

This comment has been minimized.

Copy link
@iTitus

iTitus Jun 23, 2023

Contributor

I think requires io.github.ititus.ddsiio; should be here, no?

This comment has been minimized.

Copy link
@crschnick

crschnick Jun 23, 2023

Author Owner

I don't explicitly require a module if it is loaded via the service loader as long as all the required modules are added in jlink. As I don't interact with the dds API itself, I don't need the module

This comment has been minimized.

Copy link
@iTitus

iTitus Jun 23, 2023

Contributor

I thought Java required the module to be loaded via the module-info if you want its services to be discoverable. Hmmm.

This comment has been minimized.

Copy link
@crschnick

crschnick Jun 23, 2023

Author Owner

No, it just has to present in the module path. Usually if you don't explicitly require the module though, it is not included jlink unless explicitly specify it as I did there.

requires com.sun.jna;
requires com.sun.jna.platform;
requires org.jnativehook;
Expand Down

0 comments on commit b45f11b

Please sign in to comment.